Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding outerBuild\InnerBuild structure for generate reference source #31892

Merged
merged 2 commits into from
Feb 12, 2020
Merged

adding outerBuild\InnerBuild structure for generate reference source #31892

merged 2 commits into from
Feb 12, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Feb 6, 2020

Fixes #31866

safern
safern approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This was referenced Feb 12, 2020
Closed
Closed
@Anipik
Copy link
Contributor Author

Anipik commented Feb 12, 2020

Merging this one as the failing networking test is already disabled. issue tracking the test #18090

@Anipik Anipik merged commit 3cd83d8 into dotnet:master Feb 12, 2020
@Anipik Anipik deleted the generateReferenceSourceOuterBuild branch February 24, 2020 23:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@safern safern safern approved these changes

@ericstj ericstj Awaiting requested review from ericstj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TargetFramework property isn't defined if there is no Outer-Build
4 participants
@Anipik @ViktorHofer @ericstj @safern